Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45850 )
Change subject: soc/intel/xeon_sp: Move common northbridge ACPI to nb_acpi.c
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45850/12/src/soc/intel/xeon_sp/nb_a...
File src/soc/intel/xeon_sp/nb_acpi.c:
https://review.coreboot.org/c/coreboot/+/45850/12/src/soc/intel/xeon_sp/nb_a...
PS12, Line 157: * 3A..3D PSTACK2 stack 4 IOU3
This mapping only applies to CPX-SP.
I added a comment. I think that I will move this function in later cleanup, but keep it here for now. Other work needs to happen before moving it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47ab1df3474d18643ef5ffc8199e09ea3dd32ccf
Gerrit-Change-Number: 45850
Gerrit-PatchSet: 12
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Oct 2020 16:59:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment