Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34591 )
Change subject: vc/cavium/bdk/libbdk-hal: Fix eye data memory leak
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34591/1/src/vendorcode/cavium/bdk/l...
File src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c:
https://review.coreboot.org/c/coreboot/+/34591/1/src/vendorcode/cavium/bdk/l...
PS1, Line 365: {
Looks like this vendorcode uses a different coding style... I'd be consistent with it.
Done
https://review.coreboot.org/c/coreboot/+/34591/1/src/vendorcode/cavium/bdk/l...
PS1, Line 366: eye_data
Very minor: cast this as "(void*)eye_data" to be consistent with the free() call at the end of the f […]
The (void *) cast at the end is needed to get rid of the const qualifier, which isn't needed here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34591
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63ca6d743e6610d3e3ab6bd7b0356aabdfa6f784
Gerrit-Change-Number: 34591
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 29 Jul 2019 02:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment