Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38291 )
Change subject: libpayload: Add support for link time optimization
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38291/3/payloads/libpayload/Makefil...
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38291/3/payloads/libpayload/Makefil...
PS3, Line 69: $(CPUS)
Might be important if not all CPU cores are to be used when building this.
In GCC 10 LTO linking will automatically detect the number of available cores and do the linking in parallel (regardless of what was set using -j). This just copies that behaviour since it will become the default anyway. (I'm also not sure what the auto flag is. Were you thinking of jobserver?)
https://www.phoronix.com/scan.php?page=news_item&px=GCC-10-LTO-flto-Avai...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38291
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I048f2ff6298ed0d891098942e1e8b29d35487b91
Gerrit-Change-Number: 38291
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 02 Feb 2020 19:09:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment