Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31125 )
Change subject: siemens/mc_apl2: Activate TPM support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31125/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31125/1//COMMIT_MSG@8 PS1, Line 8: Please elaborate why the GPIO needed to be changed.
https://review.coreboot.org/#/c/31125/1//COMMIT_MSG@9 PS1, Line 9: TEST=Build coreboot for mc_apl2 board and check the TPM console output. What command did you use, to check functionality under the OS like GNU/Linux?
https://review.coreboot.org/#/c/31125/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb:
https://review.coreboot.org/#/c/31125/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 86: device pci 16.1 on end # - I2C 1 : device pci 16.2 on end # - I2C 2 : device pci 16.3 on end # - I2C 3 : device pci 17.0 on end # - I2C 4 : device pci 17.1 on end # - I2C 5 : device pci 17.2 on end # - I2C 6 : device pci 17.3 on end # - I2C 7 : device pci 18.0 on end # - UART 0 : device pci 18.1 on end # - UART 1 : device pci 18.2 on end # - UART 2 : device pci 18.3 on end # - UART 3 This should be done in a separate commit.