Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42201 )
Change subject: soc/intel/skylake: Check Kconfig symbols in C instead of preprocessor
......................................................................
Patch Set 5: Code-Review-1
I would +2 this if there wasn't CB:42199 :P see my comment there
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42201
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6601bfd6e7a11eca6bbc32f6757c165ba5a4cff
Gerrit-Change-Number: 42201
Gerrit-PatchSet: 5
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Sat, 19 Sep 2020 09:34:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment