31 May
2022
31 May
'22
11:51 p.m.
Attention is currently required from: Martin L Roth. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64651 )
Change subject: mb/starlabs/lite/glkr: Disconnect unused GPIO's ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/starlabs/lite/variants/glkr/gpio.c:
https://review.coreboot.org/c/coreboot/+/64651/comment/7c0bc53a_10925a63 PS3, Line 84: PAD_NC(GPIO_27, DN_20K), : /* GPIO_28: SPI Strap */ : PAD_NC(GPIO_28, UP_20K),
Should these be set to no pull as well?
Yes, but I change it in CB:64652 - want me to move it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/64651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b071ec1d194f76ee78066396bac8dfff5ec851b
Gerrit-Change-Number: 64651
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth gaumless@tutanota.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth gaumless@tutanota.com
Gerrit-Comment-Date: Tue, 31 May 2022 20:51:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth gaumless@tutanota.com
Gerrit-MessageType: comment