Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Brandon Breitenstein, Curtis Chen.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 )
Change subject: src/ec/google/chromeec: Add and modify APIs for USB-C DP ALT mode
......................................................................
Patch Set 12:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57138/comment/5030083a_789c4473
PS12, Line 9: Add API to allow AP to send the command to EC to enter DP ALT mode,
: API to wait for DP HPD event and API to get USB-C mux related
: information. Rename google_chromeec_usb_pd_control() to
: google_chromeec_usb_pd_get_info() for better understanding. Change
: the return value of google_chromeec_wait_for_displayport()
: and google_chromeec_pd_get_amode().
Thanks for addressing the comments, Derek. […]
Thanks for reviewing. I will update patch set to address the comments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3
Gerrit-Change-Number: 57138
Gerrit-PatchSet: 12
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 29 Sep 2021 07:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment