Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33395 )
Change subject: mb/google/octopus: Override VBT selection for Garg ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/33395/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33395/6//COMMIT_MSG@19 PS6, Line 19: Cq-Depend: chrome-internal:1380847 I don't think Cq-Depend has any meaning in the upstream repository. Can someone please confirm if my understanding is correct? Also even if you are adding it, it should be grouped as part of Change-Id paragraph.
https://review.coreboot.org/#/c/33395/6/src/mainboard/google/octopus/mainboa... File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/#/c/33395/6/src/mainboard/google/octopus/mainboa... PS6, Line 121: uint32_t variant_board_sku(void) Ideally we would want this i.e. exporting variant_board_sku function as a separate patch. That way we can keep VBT selection independent. Can you please split it up?