Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38790 )
Change subject: Makefile.inc: Adapt $(spc) definition
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG@7
PS1, Line 7: gmake 4.3 is picky
Maybe put this in the commit message
Done
https://review.coreboot.org/c/coreboot/+/38790/1//COMMIT_MSG@9
PS1, Line 9: The old definition worked for nearly 8 years, RIP.
Tested and working with versions 4.3 and 4.2.1 of GNU make.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7981e0066b550251ae4a98d7b50e83049fc5586a
Gerrit-Change-Number: 38790
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-Comment-Date: Wed, 12 Feb 2020 21:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment