[coreboot-gerrit] Change in ...coreboot[master]: soc/sifive/fu540: add code to initialize flash

[Philipp Hug (Code Review)]

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30466 )

Change subject: soc/sifive/fu540: add code to initialize flash
......................................................................

Patch Set 10:

(2 comments)

Thanks!
Has this been tested on hw?

https://review.coreboot.org/#/c/30466/10/src/mainboard/sifive/hifive-unleash... 
File src/mainboard/sifive/hifive-unleashed/flash.c:

https://review.coreboot.org/#/c/30466/10/src/mainboard/sifive/hifive-unleash... 
PS10, Line 30: 	.command_code = 0x6c
please use a constant for 0x6c.
Is this?
 #define SPINOR_OP_READ4_1_1_4	0x6c	/* Read data bytes (Quad SPI) */

https://review.coreboot.org/#/c/30466/10/src/mainboard/sifive/hifive-unleash... 
PS10, Line 40: 			0x66,
same here. please use a constant or add a comment.