Attention is currently required from: Ashish Kumar Mishra, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81437?usp=email )
Change subject: lib/spd_bin: Add LPDDR5X dram_type in use_ddr4_params ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81437/comment/c079b2e9_927d8e91 : PS2, Line 16:
This patch handles the LPDDR5X case and avoids falling into default case(due to which log were seen). We're not changing anything regarding logs.
if my understanding is correct then with your patch, we won't be seeing below extra msg about falling back into default DDR4
``` [NOTE ] Defaulting to using DDR4 params. Please add dram_type check for 21 to use_ddr4_params [NOTE ] Defaulting to using DDR4 params. Please add dram_type check for 21 to use_ddr4_params [NOTE ] Defaulting to using DDR4 params. Please add dram_type check for 21 to use_ddr4_params [NOTE ] Defaulting to using DDR4 params. Please add dram_type check for 21 to use_ddr4_params ```