Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34332 )
Change subject: mediatek/mt8183: Support more DRAM frequency bootup ......................................................................
Patch Set 25:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34332/24/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/34332/24/src/soc/mediatek/mt8183/dr... PS24, Line 148: tmp_0p5t = ((read32(reg_0) >> shift) & DQ_DIV_MASK) &
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/34332/24/src/soc/mediatek/mt8183/dr... PS24, Line 552: if (!wait_us(100, read32(&ch[chn].nao.testrpt) & status)) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/c/coreboot/+/34332/25/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/34332/25/src/soc/mediatek/mt8183/dr... PS25, Line 552: if (!wait_us(100, read32(&ch[chn].nao.testrpt) & status)) @huayang Is this what you want?