Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot ......................................................................
Patch Set 15: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35239/15/util/mainboard/google/hatc... File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/15/util/mainboard/google/hatc... PS15, Line 53: # Find all files in the template tree and copy them to the target : # in the same paths, substituting the current year for __YEAR__ : # Use ``while/find -print0`` instead of ``for/in`` due to shellcheck warning : while IFS= read -r -d '' f ; do : # Because we're in the destination directory, ``find ${SRC}/template/`` : # will return filenames with a full path. We need to strip that path : # and just get the path and filename relative to ${SRC}/template/ : s="${f#"${SRC}/template/"}" : # Now create the directory tree under the destination : mkdir -p "variants/${variant}/$(dirname "${s}")" : # Use the full path and file ${f} as the source, and the relative : # path and name as the target : cp "${f}" "variants/${variant}/${s}" : : git add "variants/${variant}/${s}" : done< <(find "${SRC}/template" -type f -print0) : Had an epiphany - the loop isn't necessary, since we're not modifying the files. We can just cp -r and then git add the directory.