Attention is currently required from: Nico Huber, Angel Pons, Kyösti Mälkki, Felix Held. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52935 )
Change subject: nb/amd/agesa/family14/northbridge.c: Report missing resources ......................................................................
Patch Set 3:
(4 comments)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/52935/comment/78173221_1338efa4 PS2, Line 275: * 0xc0000 - 0xcffff: VGA OPROM
- 0xd0000 - 0xfffff: SeaBIOS, if used […]
Done
https://review.coreboot.org/c/coreboot/+/52935/comment/3741027a_c6f87c8a PS2, Line 285: Ff
typo? If
Done
https://review.coreboot.org/c/coreboot/+/52935/comment/95ee6a81_91ff83c6 PS2, Line 289: resource_t
mmio_resource() is a wrapper macro for fixed_mem_resource(), which takes arguments of `unsigned long […]
I could use unsigned long here, but not in the other situation you pointed.
https://review.coreboot.org/c/coreboot/+/52935/comment/6d16f67d_6cb70268 PS2, Line 382: // 4 1T
No idea, it was just there before. […]
Done