Attention is currently required from: Hung-Te Lin, Yidi Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53895 )
Change subject: soc/mediatek/mt8195: Configure eMMC and SDCard ......................................................................
Patch Set 1:
(6 comments)
File src/mainboard/google/cherry/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118645): https://review.coreboot.org/c/coreboot/+/53895/comment/6f2a5865_363c7525 PS1, Line 88: MSDC1_GPIO_MODE0_0, MSDC1_GPIO_MODE0_VALUE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118645): https://review.coreboot.org/c/coreboot/+/53895/comment/444d3757_090c2a10 PS1, Line 89: MSDC1_GPIO_MODE0_1, MSDC1_GPIO_MODE0_VALUE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118645): https://review.coreboot.org/c/coreboot/+/53895/comment/b0149bd8_60a9221d PS1, Line 93: MSDC1_GPIO_MODE1_0, MSDC1_GPIO_MODE1_VALUE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118645): https://review.coreboot.org/c/coreboot/+/53895/comment/9182a24d_6b6a4728 PS1, Line 94: MSDC1_GPIO_MODE1_1, MSDC1_GPIO_MODE1_VALUE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118645): https://review.coreboot.org/c/coreboot/+/53895/comment/ef30a62c_59f098be PS1, Line 95: MSDC1_GPIO_MODE1_2, MSDC1_GPIO_MODE1_VALUE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118645): https://review.coreboot.org/c/coreboot/+/53895/comment/65229edd_c6b011a8 PS1, Line 96: MSDC1_GPIO_MODE1_3, MSDC1_GPIO_MODE1_VALUE); code indent should use tabs where possible