Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40007 )
Change subject: mb/asus/p2b{,-ls}: Get rid of power button device ......................................................................
Patch Set 2:
Patch Set 2:
I looked at the vendor DSDT dump deeper. The flag in question is hardcoded in sb/intel/i82371eb/fadt.c yet matches the value in the vendor dump, yet it also has PWRB. I want to try controlling flag from a config option and flip it for boards that do have PWRB... then again it's just 3 boards in one family and they all have it. Another reason to not proceed with this change.
Looks like this issue is much more widespread. Even mb/amd/thatcher is like this - has PWRB in DSDT and the flag not set in FADT.