Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46054 )
Change subject: mb/intel/adlrvp: Add initial ADL-P mainboard code ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46054/9/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/46054/9/src/mainboard/intel/adlrvp/... PS9, Line 62: nit: extra space
https://review.coreboot.org/c/coreboot/+/46054/9/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46054/9/src/mainboard/intel/adlrvp/... PS9, Line 12: subdirs-y += ../common I don't see a src/mainboard/intel/common
https://review.coreboot.org/c/coreboot/+/46054/9/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/46054/9/src/mainboard/intel/adlrvp/... PS9, Line 34: 0 nit: space afteR )