Attention is currently required from: Jakub Czapiga, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69762 )
Change subject: vboot/vboot_logic: Fix hash digest size and padding
......................................................................
Patch Set 1:
(1 comment)
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/69762/comment/13739a42_5b414817
PS1, Line 344: uint8_t hash_digest[VBOOT_MAX_HASH_SIZE];
Should we do this in vboot_save_hash()? Seems like a weird quirk of the backing store that doesn't really belong in the common business logic code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6d46e0b58dbca86af56221b7ff2606ab2d1799a
Gerrit-Change-Number: 69762
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 18 Nov 2022 02:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment