Attention is currently required from: Lance Zhao, Philipp Hug, Tim Wawrzynczak, ron minnich.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74830 )
Change subject: ACPI,SMBIOS : Provide ACPI and SMBIOS support for RISC-V ......................................................................
Patch Set 1:
(32 comments)
File src/arch/riscv/tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/276b846a_ab0d2cd8 PS1, Line 88: const char * config_path[] = { "cfgtables" }; char * array declaration might be better as static const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/4aaa3bd3_5a1105eb PS1, Line 88: const char * config_path[] = { "cfgtables" }; "foo * bar" should be "foo *bar"
File src/include/acpi/acpi.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/59918132_6f58a713 PS1, Line 249: u32 lhxw : 4; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/c3825597_e53f68a9 PS1, Line 249: u32 lhxw : 4; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/a9abdb44_55540074 PS1, Line 249: u32 lhxw : 4; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/7ebf41f1_1c13f2a7 PS1, Line 250: u32 hhxw : 3; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/3390b72b_136335f7 PS1, Line 250: u32 hhxw : 3; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/64bbd16c_293968be PS1, Line 250: u32 hhxw : 3; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/7621b07a_d3271ffc PS1, Line 251: u32 lhxs : 3; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/3e255276_6ae54ae8 PS1, Line 251: u32 lhxs : 3; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/71974ef6_359fb1c1 PS1, Line 251: u32 lhxs : 3; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/7484b63d_ff8bfaba PS1, Line 252: u32 hhxs : 5; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/5b2addfa_d27d8af8 PS1, Line 252: u32 hhxs : 5; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/c3109429_c71be90f PS1, Line 252: u32 hhxs : 5; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/11ee7976_a81462df PS1, Line 253: u32 reserved : 17; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/3239a21d_2763e13c PS1, Line 253: u32 reserved : 17; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/34f4a136_1e1b2e8a PS1, Line 253: u32 reserved : 17; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/27054acd_47c26724 PS1, Line 261: u64 mmu_type : 4; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/f67bac9f_134a3a35 PS1, Line 261: u64 mmu_type : 4; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/e6b8f9ec_12b5cfa2 PS1, Line 261: u64 mmu_type : 4; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/1d4341b4_e3bca0d2 PS1, Line 262: u64 aia_enabled : 1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/1f4b5b7d_45a7d223 PS1, Line 262: u64 aia_enabled : 1; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/456c11b6_98ae2f8e PS1, Line 262: u64 aia_enabled : 1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/d8eebd1b_e268e95d PS1, Line 263: u64 reserved : 59; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/e81f2731_488f1636 PS1, Line 263: u64 reserved : 59; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/7d900551_3f07d960 PS1, Line 263: u64 reserved : 59; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/fca583e0_b932a9db PS1, Line 286: u32 size; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/4134476a_61673aa7 PS1, Line 286: u32 size; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/1fe55ec1_26c190fe PS1, Line 286: u32 size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/e09bc826_9897e9ff PS1, Line 312: u8 type; \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/edee9b62_1d9bc4ba PS1, Line 340: u8 type; \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175118): https://review.coreboot.org/c/coreboot/+/74830/comment/626a7dc3_a00327f6 PS1, Line 355: u8 type; \ Avoid unnecessary line continuations