Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35067 )
Change subject: mb/asrock/h110m: fix VR Settings Configuration info ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35067/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35067/2//COMMIT_MSG@15 PS2, Line 15: [1] https://review.coreboot.org/c/coreboot/+/34937 I would reference the commit hash and summary instead of the gerrit link
https://review.coreboot.org/c/coreboot/+/35067/2/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35067/2/src/mainboard/asrock/h110m/... PS2, Line 93: VrVoltageLimit
Um, Sarien makes use of this limit: […]
Oh, I just checked. There's missing PCI IDs for Skylake devices on CB:34937, so I would expand that. The idea is that boards with sockets don't need to specify extra parameters.