Jiaxin Yu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32459 )
Change subject: google/kukui: Support sound in boot process ......................................................................
Patch Set 2:
(6 comments)
Hi Hung-Te,please help to review again,thanks.
https://review.coreboot.org/#/c/32459/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32459/1//COMMIT_MSG@7 PS1, Line 7: Enable boot sound support
Support sound in boot process
Done
https://review.coreboot.org/#/c/32459/1//COMMIT_MSG@9 PS1, Line 9: gpio
GPIO
Done
https://review.coreboot.org/#/c/32459/1//COMMIT_MSG@9 PS1, Line 9: Config enable
Configure and enable
Done
https://review.coreboot.org/#/c/32459/1/src/mainboard/google/kukui/chromeos.... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/#/c/32459/1/src/mainboard/google/kukui/chromeos.... PS1, Line 42: SPK enable
Enable speaker
Done
https://review.coreboot.org/#/c/32459/1/src/mainboard/google/kukui/gpio.h File src/mainboard/google/kukui/gpio.h:
https://review.coreboot.org/#/c/32459/1/src/mainboard/google/kukui/gpio.h@26 PS1, Line 26: EN_SPK_AMP
GPIO_EN_SPK_AMP
Done
https://review.coreboot.org/#/c/32459/1/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/32459/1/src/mainboard/google/kukui/mainboard... PS1, Line 44: mtcmos_audio_power_on
Should we configure GPIOs to I2S first or power on audio first?
Usually we power on audio first and then config other audio related such as gpio mode.