[coreboot-gerrit] Change in coreboot[master]: vboot: remove extraneous vboot_recovery_mode_memory_retrain

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39343 )

Change subject: vboot: remove extraneous vboot_recovery_mode_memory_retrain
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39343/5/src/soc/mediatek/mt8183/mem... 
File src/soc/mediatek/mt8183/memory.c:

https://review.coreboot.org/c/coreboot/+/39343/5/src/soc/mediatek/mt8183/mem... 
PS5, Line 179: 		    vboot_check_recovery_request() == VB2_RECOVERY_TRAIN_AND_REBOOT) {
> so it's literally just supposed to be a recovery boot that reboots automatically.

Correct.
> It's probably wrong to have it on Kukui here then, too.

Yes, we shouldn't have it here on Kukui too.
> I thought we had a requirement to allow the system to automatically trigger a retrain from software, but I guess we don't?

No, it was just for the factory flow to ensure that the recovery cache is populated before devices are shipped.