Attention is currently required from: Nico Huber, Furquan Shaikh, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50857 )
Change subject: sb/intel/common: Refactor _PRT generation to support GSI-based tables
......................................................................
Patch Set 20:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50857/comment/d878b554_44868bf7
PS20, Line 13:
Works for me, with the 1:1 mapping for northbridge devices fixed.
Thanks Nico!
File src/southbridge/intel/common/rcba_pirq.h:
https://review.coreboot.org/c/coreboot/+/50857/comment/447fd3c0_b6950722
PS20, Line 7: #include "acpi_pirq_gen.h"
Is this needed?
Not anymore 😊
File src/southbridge/intel/common/rcba_pirq.c:
https://review.coreboot.org/c/coreboot/+/50857/comment/fe15f22b_82359f36
PS20, Line 36: return (enum pirq)pci_pin;
This will break due to the changed pirq enum.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica420a3d12fd1d64c8fe6e4b326fd779b3f10868
Gerrit-Change-Number: 50857
Gerrit-PatchSet: 20
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 12 Apr 2021 15:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment