Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )
Change subject: mediatek/mt8183: Add display driver ......................................................................
Patch Set 4:
(7 comments)
there are many function and hardware register define difference between mt8183 and mt8173
There are also many functions being the same (or identical - by specifying idx=0), for example ovl_set_roi, ovl_layer_enable, rdma_start, rdma_config, color_start, ovl_layer_config, half of main_disp_path_setup, some of mtk_ddp_mode_set.
A quick calculation, the files are having 127 lines in diff while 8183 ddp.c is 212 lines, so it's about 40% in common.
I think we may still do something, for example have few functions in common/ddp.c, and then have soc-specific part in mt*/ddp.c; but it's also true this is probably not that urgent.
https://review.coreboot.org/#/c/31478/4/src/soc/mediatek/mt8183/ddp.c File src/soc/mediatek/mt8183/ddp.c:
https://review.coreboot.org/#/c/31478/4/src/soc/mediatek/mt8183/ddp.c@161 PS4, Line 161: remove the blank line here
https://review.coreboot.org/#/c/31478/4/src/soc/mediatek/mt8183/ddp.c@163 PS4, Line 163: remove the blank line here
https://review.coreboot.org/#/c/31478/4/src/soc/mediatek/mt8183/ddp.c@165 PS4, Line 165: remove the blank line here
https://review.coreboot.org/#/c/31478/4/src/soc/mediatek/mt8183/ddp.c@167 PS4, Line 167: remove the blank line here
https://review.coreboot.org/#/c/31478/4/src/soc/mediatek/mt8183/ddp.c@169 PS4, Line 169: remove the blank line here
https://review.coreboot.org/#/c/31478/4/src/soc/mediatek/mt8183/ddp.c@171 PS4, Line 171: remove the blank line here
https://review.coreboot.org/#/c/31478/4/src/soc/mediatek/mt8183/ddp.c@173 PS4, Line 173: remove the blank line here