Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48174 )
Change subject: drivers/intel/fsp2_0: Fix running on x86_64 ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48174/5/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/48174/5/src/drivers/intel/fsp2_0/Kc... PS5, Line 36: default y Since you defaulted this to y, and still selected X86_32 in many soc Kconfig files, are you intending to flip the polarity down the road? That is, to make 64 the default and 32 the exception?
https://review.coreboot.org/c/coreboot/+/48174/5/src/drivers/intel/fsp2_0/in... File src/drivers/intel/fsp2_0/include/fsp/info_header.h:
https://review.coreboot.org/c/coreboot/+/48174/5/src/drivers/intel/fsp2_0/in... PS5, Line 39: #else Is there a new spec, or maybe an addendum, that defines the new header for 64-bit? I'm not seeing anything at intel.com/fsp yet.