Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46395 )
Change subject: soc/mediatek/mt8192: add rtc MT6359P driver ......................................................................
Patch Set 42:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46395/42/src/soc/mediatek/common/in... File src/soc/mediatek/common/include/soc/rtc_cali.h:
https://review.coreboot.org/c/coreboot/+/46395/42/src/soc/mediatek/common/in... PS42, Line 8: void rtc_osc_init(void); move to rtc_common.h
https://review.coreboot.org/c/coreboot/+/46395/42/src/soc/mediatek/common/rt... File src/soc/mediatek/common/rtc_cali.c:
PS42: rtc_osc_init.c ?
https://review.coreboot.org/c/coreboot/+/46395/42/src/soc/mediatek/common/rt... PS42, Line 7: int rtc_eosc_cali(void) static int ?
https://review.coreboot.org/c/coreboot/+/46395/42/src/soc/mediatek/mt8173/in... File src/soc/mediatek/mt8173/include/soc/rtc.h:
https://review.coreboot.org/c/coreboot/+/46395/42/src/soc/mediatek/mt8173/in... PS42, Line 9: #include <soc/pmic_wrap_common.h> in alphabet order
https://review.coreboot.org/c/coreboot/+/46395/42/src/soc/mediatek/mt8173/in... PS42, Line 127: remove extra blank line
https://review.coreboot.org/c/coreboot/+/46395/42/src/soc/mediatek/mt8183/in... File src/soc/mediatek/mt8183/include/soc/rtc.h:
https://review.coreboot.org/c/coreboot/+/46395/42/src/soc/mediatek/mt8183/in... PS42, Line 6: #include <soc/rtc_common.h> : #include <soc/pmic_wrap_common.h> : #include <soc/rtc_cali.h> in alphabet order