Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33918 )
Change subject: mb/asus/am1i-a/buildOpts.c: uncomment the RAM speed-related defines
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/33918/8/src/mainboard/asus/am1i-a/b...
File src/mainboard/asus/am1i-a/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/33918/8/src/mainboard/asus/am1i-a/b...
PS8, Line 254: /* MEMORY_BUS_SPEED */
Nothing will use these, and they seem to be defined elsewhere. Please remove them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33918
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0468d329c6efa9abffc8859a542aae0cf702863
Gerrit-Change-Number: 33918
Gerrit-PatchSet: 8
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 11 Apr 2020 10:27:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment