Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 )
Change subject: mainboard/samsung/350v5c: add initial board files and Kconfig option for 6 MB flash ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/devicet... File src/mainboard/samsung/350v5c/devicetree.cb:
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/devicet... PS1, Line 33: :
Remove all "subsystemid" entries after this point, and add this here: […]
Stupid me, it should be next to: device domain 0x0 on
https://review.coreboot.org/#/c/30942/8/src/mainboard/samsung/350v5c/devicet... File src/mainboard/samsung/350v5c/devicetree.cb:
https://review.coreboot.org/#/c/30942/8/src/mainboard/samsung/350v5c/devicet... PS8, Line 67: end This can go in the previous line:
device pci 16.1 off end # Management Engine Interface 2