Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40282 )
Change subject: mb/google/puff: Add variant specific DPTF parameters ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40282/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40282/1//COMMIT_MSG@7 PS1, Line 7: mb/google/puff: Update DPTF parameters
Add variant specific DPTF parameters
Done
https://review.coreboot.org/c/coreboot/+/40282/1//COMMIT_MSG@14 PS1, Line 14: boot on puff board
Fits on the line above.
Done
https://review.coreboot.org/c/coreboot/+/40282/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/40282/1/src/mainboard/google/hatch/... PS1, Line 38: #define DPTF_TSR1_ACTIVE_AC0 50
Please use tabs as above.
Done