27 Jan
2021
27 Jan
'21
12:25 p.m.
Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49477 )
Change subject: ACPI: Separate ChromeOS NVS in ASL ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/vendorcode/google/chromeos/acpi/gnvs.asl:
https://review.coreboot.org/c/coreboot/+/49477/comment/4448540c_be0111cb PS6, Line 28: // 0xdd6 nit: keep lined up with the others
--
To view, visit https://review.coreboot.org/c/coreboot/+/49477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54b0d63a41561f9a5d9ebde77967e6d21ee014cd
Gerrit-Change-Number: 49477
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 27 Jan 2021 20:25:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment