Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43979 )
Change subject: drivers/intel/fsp2_0: Change boot state notification
......................................................................
Patch Set 4:
(2 comments)
Does anyone know why we load the payload into memory and then notify FSP? Doesn't it make sense to:
1. notify FSP of boot state init
2. load payload into memory
3. run payload
https://review.coreboot.org/c/coreboot/+/43979/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43979/3//COMMIT_MSG@7
PS3, Line 7: drivers/intel/fsp2_0: Change boot state notification
Add an empty line after the commit summary
Done
https://review.coreboot.org/c/coreboot/+/43979/3//COMMIT_MSG@19
PS3, Line 19: This prevents code corruption of payload. At this stage of boot, there is no
nit: wrap at 72 characters
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I122edc12abf992cb3e5ec53747a7cef9c94aee8e
Gerrit-Change-Number: 43979
Gerrit-PatchSet: 4
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 29 Jul 2020 17:19:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment