Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34599 )
Change subject: lib/coreboot_table: Show splashscreen in lb_table_init ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34599/7/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/34599/7/src/lib/coreboot_table.c@48 PS7, Line 48: #include <bootsplash.h> Just place it after <bootmem.h>.
https://review.coreboot.org/c/coreboot/+/34599/7/src/lib/coreboot_table.c@15... PS7, Line 150: if (CONFIG(BOOTSPLASH)) { Previously, there may have been some combination of Kconfigs where bootsplash was drawn on S3 resume path. I am fine with the change, maybe worth mentioning in the commit message S3 resume will never show bootsplash.
The approach here may delay the showing of bootsplash by some hundred milliseconds or so, depending of how slow PCI init functions the platform has. I would rather see the call made outside coreboot-table but apparently Nico was against hooking to boot states?