29 Apr
2019
29 Apr
'19
5:07 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32485 )
Change subject: soc/intel/common: Add new PAD_CFG macro. ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32485/5/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/#/c/32485/5/src/soc/intel/common/block/include/i... PS5, Line 248: PAD_CFG_GPI_GPIO_DRIVER_SCI Let's still put this under SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT in line 394.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32485
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0332c64e2fa62ce29c772444606adbfdf9c9afc4
Gerrit-Change-Number: 32485
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Apr 2019 17:07:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment