[coreboot-gerrit] Change in coreboot[master]: sconfig: Allow to link devices to other device' drivers

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35456 )

Change subject: sconfig: Allow to link devices to other device' drivers
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35456/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35456/4//COMMIT_MSG@32 
PS4, Line 32:             use my_eeprom as needed_eeprom
> I don't like `register` either. […]

whoops, I got the names backwards, but you see my point.

I totally agree with the naming convention; `register` doesn't make any sense in general the way we use it, but I just don't see why this case should be different than any other. At the end of the day, we're just setting fields in struct blah_config.

On a related note, I would consider +2'ing a patch that changed `register` to something different 😉