Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33024 )
Change subject: crossgcc: Add nasm to toolchain
......................................................................
Patch Set 4:
Patch Set 3:
this doesn't include nasm getting built as part of any arch-specific target, eg crossgcc-i386, which I assume is how many users build their tooolchain. Do we want to add it?
Added. It will now try to build nasm a couple extra times when building everything but the builder will bail when it sees that it's already successfully built, so it shouldn't add much additional time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I086cbe6c46f7c09b2a7a83e177b32fd1bdf99266
Gerrit-Change-Number: 33024
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:06:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment