Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33146 )
Change subject: Documentation: How to run coreboot on PC Engines APU2
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Thank you!
https://review.coreboot.org/#/c/33146/4//COMMIT_MSG
Commit Message:
PS4:
I would suggest using present tense in commit messages, e.g.:
Documentation: Add PC Engines apu2
Describe how to run coreboot on the PC Engines apu2 mainboard.
https://review.coreboot.org/#/c/33146/4/Documentation/mainboard/pcengines/ap...
File Documentation/mainboard/pcengines/apu2_spi.jpg:
PS4:
Excellent picture.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33146
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1d553c7f7485358960d92e714d50ba0f75b3581
Gerrit-Change-Number: 33146
Gerrit-PatchSet: 4
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 10 Jun 2019 10:21:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment