build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39613 )
Change subject: Sc7180: Add display 10nm phy & pll programming support ......................................................................
Patch Set 31:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39613/31/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi_phy.c:
https://review.coreboot.org/c/coreboot/+/39613/31/src/soc/qualcomm/sc7180/di... PS31, Line 130: if (DSI_LANEID_CLK == lane) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/c/coreboot/+/39613/31/src/soc/qualcomm/sc7180/di... PS31, Line 135: if (DSI_LANEID_0 == lane) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/c/coreboot/+/39613/31/src/soc/qualcomm/sc7180/di... PS31, Line 187: if (DSI_LANEID_CLK == lane) Comparisons should place the constant on the right side of the test