Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )
Change subject: mb/google/dedede: Add SD card support ......................................................................
Patch Set 26:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded... PS23, Line 284: GPP_G7
Thanks for the confirmation, Aamir!
Furquan , I further checked setting the WP as NF1 and adding a 20K PD. I see a clean dmesg now for mmc0. earlier below errors were seen. [ 8.346777] mmcblk0: recovery failed! [ 8.351034] blk_update_request: I/O error, dev mmcblk0, sector 0 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
https://review.coreboot.org/c/coreboot/+/39237/25/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/25/src/mainboard/google/deded... PS25, Line 272: NATIVE
I think the reason you are setting this to NATIVE is because the controller would want to pull up to […]
correct. I added the native termination for SD clk as well. EDS(vol 1 10.4.10) recommends setting native for CMD, DATA and CLK signals.
After setting the CLK terminati to native on the clock tuning errors are not seen.