Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41900 )
Change subject: drivers/usb/pci_xhci: Add a driver to generate xHCI ACPI nodes ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41900/3/src/drivers/xhci/acpi/xhci_... File src/drivers/xhci/acpi/xhci_acpi.c:
https://review.coreboot.org/c/coreboot/+/41900/3/src/drivers/xhci/acpi/xhci_... PS3, Line 92: counts
Aah! You are basically using it to generate unique HS/SS names. […]
That's exactly what this does. xhci_add_devices is called once per XHC.
We need to keep state for the callback to count the number of ports we have allocated. For Picasso at least, the USB3 descriptors only describe 1 port each.
xHCI SSDT generation xHCI Supported Protocol: Major: 0x2, Minor: 0x0, Protocol: 'USB ' Port Offset: 1, Port Count: 4 xHCI Supported Protocol: Major: 0x3, Minor: 0x10, Protocol: 'USB ' Port Offset: 5, Port Count: 1 xHCI Supported Protocol: Major: 0x3, Minor: 0x10, Protocol: 'USB ' Port Offset: 6, Port Count: 1 xHCI Supported Protocol: Major: 0x3, Minor: 0x10, Protocol: 'USB ' Port Offset: 7, Port Count: 1 xHCI Supported Protocol: Major: 0x3, Minor: 0x10, Protocol: 'USB ' Port Offset: 8, Port Count: 1
xHCI SSDT generation xHCI Supported Protocol: Major: 0x2, Minor: 0x0, Protocol: 'USB ' Port Offset: 1, Port Count: 2 xHCI Supported Protocol: Major: 0x3, Minor: 0x10, Protocol: 'USB ' Port Offset: 3, Port Count: 1 EC returned error result code 2 PS2K: Bad resp from EC. Vivaldi disabled!