Attention is currently required from: Marek Maślanka, Subrata Banik.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )
Change subject: soc/intel/common/block: Add support for watchdog ......................................................................
Patch Set 9:
(3 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/79909/comment/1cda89ce_bc8b2c9a : PS9, Line 405: wdat->min_count = 1; Can we be sure this value is always correct? Is there a way to get this value from somewhere in TCO maybe?
https://review.coreboot.org/c/coreboot/+/79909/comment/253dfe35_46bf602f : PS9, Line 406: tco_get_timer_max_value() * tco_get_timer_period() / 1000; I think this code should be protected against overflow with u64 used for calculations before assigning.
https://review.coreboot.org/c/coreboot/+/79909/comment/da7b03f8_c2de7795 : PS9, Line 443: entry->mask = 0x02; Why is set mask different from get mask above?