Attention is currently required from: Marek Maślanka, Subrata Banik.
3 comments:
File src/soc/intel/common/block/acpi/acpi.c:
Patch Set #9, Line 405: wdat->min_count = 1;
Can we be sure this value is always correct? Is there a way to get this value from somewhere in TCO maybe?
Patch Set #9, Line 406: tco_get_timer_max_value() * tco_get_timer_period() / 1000;
I think this code should be protected against overflow with u64 used for calculations before assigning.
Patch Set #9, Line 443: entry->mask = 0x02;
Why is set mask different from get mask above?
To view, visit change 79909. To unsubscribe, or for help writing mail filters, visit settings.