SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34581 )
Change subject: mb/google/kohaku: Enable stylus pen device ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/... PS4, Line 66: /* H4 : PCH_I2C_PEN_SDA */ : PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), : /* H5 : PCH_I2C_PEN_SCL */ : PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), :
Yeah, I believe it is based on the SerialIoDevConfig.
Thanks for the explanation.
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/... PS4, Line 87: ACPI_GPIO_IRQ_LEVEL_LOW
If the expectation is GpioIO() to be provided, then we should change this and the hatch/overridetree […]
ACPI_GPIO_IRQ_EDGE_BOTH makes reverse pen ejection event action. Insert - Display pen pop-up window and cause wake from suspend Eject - Hide pop-up window
Both ACPI_GPIO_IRQ_LEVEL_LOW and ACPI_GPIO_INPUT_ACTIVE_LOW are okay for the pen ejection event - pop-up window and wake operation. Can you check what we should use?