Attention is currently required from: Subrata Banik, Terry Chen, Tim Wawrzynczak, Nick Vaccaro, Franklin Lin.
Paz Zcharya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68868 )
Change subject: mb/google/brya: Update Crota's ELAN touchscreen delay to 150 ms
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/crota/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68868/comment/c738ac9e_3ee6c8f1
PS6, Line 225: 150
Spec requires 150 ms minimum delay in between pulling RESET high and sending the first i2c commands. […]
Tarun pointed out that the delay requirement depends on the type of communication (ack vs. hid). Running this by ELAN to confirm which one is relevant in that case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea
Gerrit-Change-Number: 68868
Gerrit-PatchSet: 6
Gerrit-Owner: Paz Zcharya
pazz@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Franklin Lin
franklin_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Franklin Lin
franklin_lin@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 26 Oct 2022 14:39:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paz Zcharya
pazz@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment