Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27277 )
Change subject: soc/amd/common: Fix AmdLateRunApTask() ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/27277/4/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/27277/4/src/soc/amd/common/block/pi/agesawra... PS4, Line 374: When we reach here, we have either
Func==AGESA_RUNFUNC_ONAP or Func==AGESA_RUNFUNC_ON_ALL_APS
Looking into implementation of AmdLateRunApTask() it's expected FunctionNumber equals one of the entries in ApDispatchTable.
In CarrizoPi, cpuF15CzBtcBefore() and RUN_BTC_ON_ALL_APS is sort of example what happens.
https://review.coreboot.org/#/c/27277/4/src/soc/amd/common/block/pi/agesawra... PS4, Line 370: : : : : : :
Have you verified that AGESA actually fills these parameters of ApExeParams?
Seems to, I was mostly staring at that FunctionNumber field.