11 Oct
2020
11 Oct
'20
9:14 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46034 )
Change subject: drivers/wifi/generic: Add support for generating SMBIOS data ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46034/2/src/drivers/wifi/generic/ge... File src/drivers/wifi/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/46034/2/src/drivers/wifi/generic/ge... PS2, Line 293: #if CONFIG(GENERATE_SMBIOS_TABLES)
Actually, `get_smbios_data` structure member definition itself is guarded using #if CONFIG(GENERATE_ […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/46034
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3c056718bdc57f6976ce8e3f8acc7665ec3ccd7
Gerrit-Change-Number: 46034
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 11 Oct 2020 18:14:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment