[coreboot-gerrit] [XS] Change in coreboot[main]: acpi.c: Fix generating pointer to cb_tables located >4G

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Benjamin Doron, Cliff Huang, Eric Lai, Hannah Williams, Jamie Ryu, Lance Zhao, Maximilian Brune, Paul Menzel, Pratikkumar V Prajapati, Tim Wawrzynczak.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76181?usp=email )

Change subject: acpi.c: Fix generating pointer to cb_tables located >4G
......................................................................

Patch Set 15:

(1 comment)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/76181/comment/303440d6_3fcb8750 :
PS15, Line 301: if (base + size - 1 <= UINT32_MAX)
              : 		acpigen_write_mem32fixed(0, base, size);
              : 	else
              : 		acpigen_resource_consumer_mmio(base, base + size - 1,
              : 					       MEM_RSRC_FLAG_MEM_READ_ONLY
              : 					       | MEM_RSRC_FLAG_MEM_ATTR_CACHE);
> wouldn't it also work when we just use acpigen_resource_consumer_mmio in all cases?

had a look at the producer ranges written in the amd domain reporting code and i used acpigen_resource_producer_mmio in all cases which passed all my tests on both windows and linux. so i'd expect that no different handling for the above vs below 4GB case is needed here