Attention is currently required from: Raul Rangel, Furquan Shaikh, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46484 )
Change subject: cbfs: Move stage header into a CBFS attribute
......................................................................
Patch Set 22:
(2 comments)
File util/cbfstool/cbfs_image.c:
https://review.coreboot.org/c/coreboot/+/46484/comment/99bb1ceb_8c93fd02
PS22, Line 1337: static int cbfs_print_stage_info(struct cbfs_file *entry, FILE* fp)
"foo* bar" should be "foo *bar"
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/46484/comment/23a7420a_a05fca09
PS22, Line 1166: ERROR("Not enough scratch space to decompress LZ4 in-place -- increase BSS size or disable compression!\n");
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46484
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8471ad7494b07599e24e82b81e507fcafbad808a
Gerrit-Change-Number: 46484
Gerrit-PatchSet: 22
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 17 Feb 2021 11:51:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment