Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49213 )
Change subject: soc/intel/common/uart: Use simple(_s_) variants of PCI functions ......................................................................
Patch Set 2:
Patch Set 1:
Patch Set 1:
Patch Set 1:
I'd rather take approach of dropping __SIMPLE_DEVICE__ entirely and always pass struct device *.
I was trying to avoid the usage of struct device * where possible so that it doesn't pull in the references to all other devices unnecessarily in early stages.
If you skip walking the devicetree and use alias instead, you can also remove all the tree topology aka links for the early stages. I have such commit somewhere locally.
That is where I am planning to head towards eventually. But, it requires adding aliases for the SoCs and updating all relevant common/ and soc/ specific code. Until I can get there I am taking smaller steps to clean up in little chunks to get some space freed up for mainboards that are hitting the limit for bootblock.