Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45317 )
Change subject: mb/asrock: Add ASRock H77 Pro4-M mainboard ......................................................................
Patch Set 2: Code-Review+1
(15 comments)
Looks good, I hope you can recover the board. I once replaced the EC on a laptop mainboard and it made no difference at all... Then I found a shorted MOSFET and the board came back to life. 😊
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@14 PS2, Line 14: Pro4 Pro3
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@19 PS2, Line 19: - PS/2 mouse or keyboard Both work, only one port?
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@25 PS2, Line 25: - All eight SATA ports 6 on the PCH and 2 on ASM1061 PCIe-to-SATA bridge
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@32 PS2, Line 32: - S3 suspend/resume from either Linux or Windows 10. Now it immediately : resumes. That means Super I/O power management is bonkers.
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@36 PS2, Line 36: Booting from the two SATA ports provided by the ASM1061 Same story with Asus P8H61-M PRO
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@38 PS2, Line 38: Internal flashing with flashrom-1.2 (no write permission on BIOS : region). Even with coreboot?
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@40 PS2, Line 40: - The ME on my board. While measuring on the Super I/O pins during S3 : suspend I probably shorted something. Since then the ME has trouble : coming up and the vendor BIOS doesn't work anymore. coreboot works. : I'm now testing with `me_cleaner -S` applied. Tried fresh ME firmware? You can use the Instant Flash image from https://www.asrock.com/mb/Intel/H77%20Pro4-M/index.asp#BIOS as it contains all regions.
https://review.coreboot.org/c/coreboot/+/45317/1/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/Kconfig:
https://review.coreboot.org/c/coreboot/+/45317/1/src/mainboard/asrock/h77pro... PS1, Line 3: H77PRO4_M
Yes. […]
Well, for now it's not a big deal. It's just that the LGA1155 boards are inconsistent with the LGA1150 boards 😄
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/Kconfig:
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... PS2, Line 11: INTEL_INT15 Drop this since no INT15 handler is installed.
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... PS2, Line 29: default "src/mainboard/$(MAINBOARDDIR)/data.vbt" Add an empty line between Kconfig options
https://review.coreboot.org/c/coreboot/+/45317/1/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45317/1/src/mainboard/asrock/h77pro... PS1, Line 4: bootblock-y += gpio.c
Build fails when I remove it. It seems to be called in src/southbridge/intel/bd82x6x/early_pch. […]
Ack, I saw. I don't like `early_init` files being built in two stages for that very reason.
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... PS2, Line 1: /* dummy */ just keep it empty
https://review.coreboot.org/c/coreboot/+/45317/1/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/45317/1/src/mainboard/asrock/h77pro... PS1, Line 11: #include "superio/nuvoton/nct6776/acpi/superio.asl"
I was able to install and use Windows 10 without a change here, but later I will try what you sugges […]
Alright. If Windows booted, this is good enough for now.
https://review.coreboot.org/c/coreboot/+/45317/1/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/45317/1/src/mainboard/asrock/h77pro... PS1, Line 70: /* FIXME: Put proper SPD map here. */
Thanks for explaining how to check. Boots with a single DIMM in any slot.
It's the "standard" mapping
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... PS2, Line 13: HDMI3, nit: Which is HDMI, and which is DVI? Feel free to add comments