Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )
Change subject: soc/amd/picasso: Update northbridge
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34424/14//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34424/14//COMMIT_MSG@9
PS14, Line 9: is
are
https://review.coreboot.org/c/coreboot/+/34424/14/src/soc/amd/picasso/northb...
File src/soc/amd/picasso/northbridge.c:
https://review.coreboot.org/c/coreboot/+/34424/14/src/soc/amd/picasso/northb...
PS14, Line 217:
What about the case where base < adj_bot && limit > adj top? Update adj_bot and adj_top then disable the mmio reg?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44a4a97765151fbcfe4c5d8de200e3e015aaaf2e
Gerrit-Change-Number: 34424
Gerrit-PatchSet: 14
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Comment-Date: Sun, 20 Oct 2019 18:08:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment